fix: Address column mapping edge case in protocol validation #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 84.67% 84.69% +0.02%
==========================================
Files 122 122
Lines 32741 32793 +52
Branches 32741 32793 +52
==========================================
+ Hits 27722 27775 +53
+ Misses 3674 3673 -1
Partials 1345 1345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
ColumnMapping is implicitly enabled for reader version 2. This means a protocol with the following should be valid.
protocol: {min_reader_version: 2, min_writer_version: 7, writerFeatures: ["columnMapping"]}How was this change tested?
Created a table with
protocol: {min_reader_version: 2, min_writer_version: 7, writerFeatures: ["columnMapping"]}and read it with the fixed code.